Add TCX support #1478
Open
Add TCX support #1478
+1,583
−512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelroquetto
force-pushed
the
tcx_support
branch
from
963f892 to
d1adae7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1478 +/- ##
==========================================
- Coverage 81.44% 80.19% -1.25%
==========================================
Files 149 153 +4
Lines 15268 15619 +351
==========================================
+ Hits 12435 12526 +91
- Misses 2233 2485 +252
- Partials 600 608 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rafaelroquetto
force-pushed
the
tcx_support
branch
from
d1adae7 to
5ddde6f
Compare
rafaelroquetto
force-pushed
the
tcx_support
branch
8 times, most recently
from
d3c9b36 to
3ab153f
Compare
This is a variant of the existing interface filter present in the 'agent' package.
rafaelroquetto
force-pushed
the
tcx_support
branch
from
3ab153f to
bb6b4a5
Compare
rafaelroquetto
force-pushed
the
tcx_support
branch
2 times, most recently
from
f49b69b to
6588c47
Compare
rafaelroquetto
force-pushed
the
tcx_support
branch
from
6588c47 to
28d807f
Compare
rafaelroquetto
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors and replaces the TC attachment code to enable the usage of TCX, introduced in Linux 6.6, for traffic control attachments. The TCX interface provides several advantages in relation to the legacy netlink attachment such as, the ability to easily chain attach tc filters to a given interface and to bypass/ignore the creation of clsact qdiscs altogether, to name a few.
The old netlink-based attachment code has been replaced by an interface called
TCManager, for which two implementations are provided: one that continues to use netlink, and another that relies on TCX. A new configuration option calledBEYLA_BPF_TC_BACKENDhas been introduced to allow the user to select which backend to use (originally I had intended to auto detect it, but that proved to be more complicated than what I'd anticipated so I decided to drop it for now, to get this out of the door). The default backend continues to be the legacy netlink one, makingtcxeffectively an opt-in feature to prevent unintended breakages.This also completes the work of bringing together the tracers and netolly attachment code.
This is a big PR and is best reviewed on a per-commit basis.